CUNY Academic Commons

Please add Laurie as a watcher on this ticket.

I asked for her help, and she replied:

Hi Steve and Marilyn,

Could the different views be a function of whether or not you are viewing the group as signed in (or not) to the Commons?

When I am signed in, I can see the posts and nested comments as desired (i.e. they are not chronological). But when I view the same URL and I am not signed in, I see posts in chronological order. Steve, will you test this to see if you experience this too? This might not be it but I thought it was worth mentioning. I couldn't determine log in status from from the screenshots.

I think you all have already clarified this but I wanted to add that the "quote" button does not nest the comment under another post but instead adds the response to the end of the chronological feed with a call out of the quoted post. This is not the button you want students to use to reply. If students are trying to make a nested comment (i.e. a comment replying to another post), they will need to his "reply" on the post to which they would like to respond. Upon clicking reply, they will be brought to the writing field at the bottom of the page to submit their reply. So, students need to use the "reply" function in order to create a nested comment (a reply to another post) that appear out of chronological order.

Let me know if the signed in/out view might be the issue here. If not I can start a ticket with the developers.

Thanks,

Laurie

I replied:

Laurie -

Even when I'm logged in, the replies from Steve are all at the end. See here - https://commons.gc.cuny.edu/groups/eas-217-f20/forum/topic/global-impacts-video/page/3/

- Marilyn

Perhaps I spoke too soon! He just wrote "Just to update, today, when I went to use the site, it worked OK. There is one post that seemed to not work for me to reply to (triggered a bunch of errors, and I can probably document that with a video if it would be helpful). But the main problem that inspired my email to the help desk doesn’t seem to be happening at the moment.

So I no longer need help, it seems. But if you want to work on fixing bugs and so forth, please send me your full email addresses and I’ll try to put you on as admins and/or provide better documentation of the error(s).

FYI I am using Safari browser on a MacOS Mojave, but it also happened when I switched to Firefox"

Laurie - See my comment at https://redmine.gc.cuny.edu/issues/13341#note-4. This is a user setting at My Settings > Forums. I think we could discuss whether and how the defaults should work; and we might consider some additional UI to make it clearer whether you've enabled threading (or even a quick link to toggle on a per-thread basis - didn't we once have this?), but the basic answer to the discrepancy in your screenshots is that different users have different settings.

I'm looking into it. Perhaps it has something to do with bbPress 2.6 because we never received these reports for bbPress 2.5.

There are two differing issues being reported here:

1. The "Quote" button doesn't use the reply ID. I can confirm that this is a bug.
2. The user forum display setting doesn't seem to stick. Not sure what is happening here. My guess is that this might be a result of caching, but I'm still looking into this.

The default display option on the forums is threaded for logged-in users. If you are logged out, it reverts to linear oldest. As reported, the issue is the threaded display option wasn't persisting on certain page loads and can sometimes revert to linear mode.

Boone, the walker for threaded replies in bbPress depends on the following code being executed:
- https://github.com/bbpress/bbPress/blob/master/src/includes/replies/template.php#L212
- https://github.com/bbpress/bbPress/blob/master/src/includes/common/classes.php#L270

For some reason, $bbp->reply_query->found_posts was sometimes empty, which prevented the backfilling of the reply_to property for each bbPress post. I've added a hotfix for the threaded display in mu-plugins/ray.php, which injects the 'reply_to' property if it is missing. The relevant code is the bbp_has_replies filter. I will commit this later if I cannot determine how $bbp->reply_query->found_posts was wiped out.

I still have to work on the "Quote" button reply to issue.

Thanks for digging into this, Ray.

I will commit this later if I cannot determine how $bbp->reply_query->found_posts was wiped out.

Totally off the top of my head, but I wonder whether advanced-post-cache might be related?

Totally off the top of my head, but I wonder whether advanced-post-cache might be related?

Good catch, Boone. I wasn't aware that this plugin was active on production.

This does seem to be the cause of the problem. I think the workaround I have in place will fix this problem for the bbPress replies loop. I will commit this in a bit.

I also noticed that the advanced-post-cache plugin does have some updates to disable certain post types from caching via new filters. We do have a custom patch to advanced-post-cache because our object cache uses a different signature: https://github.com/cuny-academic-commons/cac/commit/387d92f3625a6a2f18d6100a4930e8343cd8bba2#diff-acdec80a18202cfcf4a70a740d254a68. So that is something to keep in mind if we decide to update to the latest version.

Both of the main issues in this ticket should now be addressed.

Thanks for digging into this so thoroughly.

I've opened https://redmine.gc.cuny.edu/issues/13358 to discuss UI improvements related to the defaults and a potential toggle.