Project

General

Profile

Bug #13994

Some Site icons missing on Site archive

Added by Sonja Leix 10 months ago. Updated 3 months ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
BuddyPress (misc)
Target version:
Start date:
2021-02-16
Due date:
% Done:

0%

Estimated time:

Description

I'm seeing a lot of the site icons missing images and displaying overflow meta text. See screenshot.
Here is an example: https://commons.gc.cuny.edu/sites/?filters%5Bkeyword%5D=english&order-by=active&bpage=2

I wonder if we need to define a fallback image to prevent this.


Related issues

Related to CUNY Academic Commons - Design/UX #14712: Default avatar imagesResolved2021-08-12

History

#1 Updated by Boone Gorges 10 months ago

  • Assignee set to Raymond Hoh
  • Target version set to 1.18.5

This is likely related to the change in #1173. Ray, could you have a look, and ensure we fall back on something that makes sense?

#2 Updated by Raymond Hoh 10 months ago

  • Category name set to BuddyPress (misc)
  • Status changed from New to In Progress

There were some changes to the site icon in BuddyPress 7.0, which affected us.

See https://bpdevel.wordpress.com/2020/11/01/meet-the-new-default-avatar-for-sites/.

I'm looking into it.

#3 Updated by Raymond Hoh 10 months ago

In BuddyPress 7.0, a new, default site icon was introduced. This icon is used if one isn't set from the site's admin dashboard.

It looks like this:

We have some custom code that broke this display (also found a bug in BuddyPress!). Do we want this to be the default site icon? It's a little bland.

Or do we want to revert to the previous, random retro, arcade-inspired icons. Here's one example:

Similarly, BuddyPress introduced a default group icon back in v2.6, but we're not using it.

It looks like this:

We chose to use the retro icons instead. See #1625. Maybe it's worth revisiting our icon defaults with a fresh set of eyes.

#4 Updated by Sonja Leix 10 months ago

Thanks Ray for looking into this. I'd say let's use the new default icon (grey). The redesign will be a lot cleaner and more modern, I'm not sure if the retro really still works and we might overall want to phase it out. Using the grey icon might perhaps also be an incentive for site owners to add a custom site icon to stand out.

#5 Updated by Boone Gorges 10 months ago

+1 to the grey icons. The retro ones are too busy for my taste. But I recall that Matt previously cast the deciding vote for the retro icons, so maybe let him weigh before making the final call.

#6 Updated by Raymond Hoh 10 months ago

If we want something a bit more neutral, but still random, identicon is not bad.

Here's an example:

#7 Updated by Sonja Leix 10 months ago

That still looks retro to me :/
I'd opt for neutral, but am curious what Matt thinks.

#8 Updated by Raymond Hoh 9 months ago

Matt, do you want to chime in here about the site icon default and icon defaults in general?

For now, I'm going to go with what we had before just so we don't have a broken site icon display and can adjust again once we've made a decision. See https://github.com/cuny-academic-commons/cac/commit/7df419ef6d969cbb19478ed6d40657bd7ed99e07.

#9 Updated by Boone Gorges 9 months ago

  • Target version changed from 1.18.5 to 1.18.6

#10 Updated by Raymond Hoh 9 months ago

From the dev call, the proposal is to change our default icons for sites and groups to use the BuddyPress defaults.

Site:

Group:

I also brought up whether we should use the BuddyPress default for users as well since we're making these icon changes. This is what the default user icon looks like:

Matt was kind of partial to identicons, but wasn't sure about whether the identicon color scheme would stand out enough.

We could decide to make these icon changes as part of the new redesign as well.

#11 Updated by Sonja Leix 9 months ago

Thanks Ray, I'm ok with whatever Matt wants to do, but might revisit this when we get to this part of the site during the redesign process.

#12 Updated by Matt Gold 9 months ago

Hi All -- thanks for giving me time to think about this. I'm fine with going with the gray icons if that's what the rest of the team prefers.

#13 Updated by Boone Gorges 9 months ago

  • Target version changed from 1.18.6 to 1.18.7

#14 Updated by Boone Gorges 8 months ago

  • Target version changed from 1.18.7 to 1.18.8

#15 Updated by Boone Gorges 8 months ago

  • Target version changed from 1.18.8 to 1.18.9

#16 Updated by Boone Gorges 7 months ago

  • Target version changed from 1.18.9 to 1.18.10

#17 Updated by Boone Gorges 7 months ago

  • Target version changed from 1.18.10 to 1.18.11

#18 Updated by Boone Gorges 6 months ago

  • Target version changed from 1.18.11 to 1.18.12

#19 Updated by Boone Gorges 6 months ago

  • Target version changed from 1.18.12 to 1.18.13

#20 Updated by Boone Gorges 5 months ago

  • Target version changed from 1.18.13 to 1.18.14

#21 Updated by Boone Gorges 5 months ago

  • Target version changed from 1.18.14 to 1.18.15

#22 Updated by Boone Gorges 4 months ago

  • Target version changed from 1.18.15 to 1.18.16

#23 Updated by Boone Gorges 4 months ago

  • Target version changed from 1.18.16 to 1.18.17

#24 Updated by Raymond Hoh 3 months ago

#25 Updated by Raymond Hoh 3 months ago

  • Status changed from In Progress to Resolved

#14712 is a new ticket describing what we want to do for default avatars, so going to close this one.

#26 Updated by Colin McDonald 3 months ago

Thanks for consolidating these, Ray.

Colin

Also available in: Atom PDF