Some Site icons missing on Site archive
I'm seeing a lot of the site icons missing images and displaying overflow meta text. See screenshot.
Here is an example: https://commons.gc.cuny.edu/sites/?filters%5Bkeyword%5D=english&order-by=active&bpage=2
I wonder if we need to define a fallback image to prevent this.
#2 Updated by Raymond Hoh 5 months ago
- Category name set to BuddyPress (misc)
- Status changed from New to In Progress
There were some changes to the site icon in BuddyPress 7.0, which affected us.
I'm looking into it.
#3 Updated by Raymond Hoh 5 months ago
In BuddyPress 7.0, a new, default site icon was introduced. This icon is used if one isn't set from the site's admin dashboard.
It looks like this:
We have some custom code that broke this display (also found a bug in BuddyPress!). Do we want this to be the default site icon? It's a little bland.
Or do we want to revert to the previous, random
retro, arcade-inspired icons. Here's one example:
Similarly, BuddyPress introduced a default group icon back in v2.6, but we're not using it.
It looks like this:
We chose to use the
retro icons instead. See #1625. Maybe it's worth revisiting our icon defaults with a fresh set of eyes.
#4 Updated by Sonja Leix 5 months ago
Thanks Ray for looking into this. I'd say let's use the new default icon (grey). The redesign will be a lot cleaner and more modern, I'm not sure if the retro really still works and we might overall want to phase it out. Using the grey icon might perhaps also be an incentive for site owners to add a custom site icon to stand out.
#8 Updated by Raymond Hoh 5 months ago
Matt, do you want to chime in here about the site icon default and icon defaults in general?
For now, I'm going to go with what we had before just so we don't have a broken site icon display and can adjust again once we've made a decision. See https://github.com/cuny-academic-commons/cac/commit/7df419ef6d969cbb19478ed6d40657bd7ed99e07.
#10 Updated by Raymond Hoh 5 months ago
From the dev call, the proposal is to change our default icons for sites and groups to use the BuddyPress defaults.
I also brought up whether we should use the BuddyPress default for users as well since we're making these icon changes. This is what the default user icon looks like:
Matt was kind of partial to identicons, but wasn't sure about whether the identicon color scheme would stand out enough.
We could decide to make these icon changes as part of the new redesign as well.