Project

General

Profile

Bug #14017

Editing of blog post leads to group notification

Added by Matt Gold 7 months ago. Updated 5 months ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Group Blogs
Target version:
Start date:
2021-02-21
Due date:
% Done:

0%

Estimated time:

Description

Hi Boone and Ray -- it looks like we've had a reemergence of an old issue (I'll link some associated tickets after submitting this) -- Luke edited a CUNY Pie post today ( https://cunypie.commons.gc.cuny.edu/2009/09/18/two-larges-at-lombardis/ ), which triggered an email notification to the associated group. While it was awesome to be reminded of good pizza, a notification should not have gone out.


Related issues

Related to CUNY Academic Commons - Bug #8535: Blog post edit triggers group notificationResolved2017-08-15

Related to CUNY Academic Commons - Bug #8183: Edit of Post creates notification emailsResolved2017-05-22

History

#1 Updated by Matt Gold 7 months ago

  • Related to Bug #8535: Blog post edit triggers group notification added

#2 Updated by Matt Gold 7 months ago

  • Related to Bug #8183: Edit of Post creates notification emails added

#3 Updated by Raymond Hoh 7 months ago

This email was sent because the blog post is very old and there was never an activity item generated for it. So when Luke made an update to the post, the BP Groupblog plugin generated an activity item for it and our group email subscription plugin will send this out to the group.

We can automatically add some logic to block edited posts that do not have a corresponding activity item and are older than, let's say, one month (or one week) from being sent out. What does everyone think?

#4 Updated by Boone Gorges 7 months ago

  • Category name set to Group Blogs
  • Target version set to 1.18.6

We can automatically add some logic to block edited posts that do not have a corresponding activity item and are older than, let's say, one month (or one week) from being sent out. What does everyone think?

Yes, this seems right to me. Emphasis on the "do not have a corresponding activity item", as this will effectively limit the block to really old posts.

#5 Updated by Boone Gorges 7 months ago

  • Target version changed from 1.18.6 to 1.18.7

#6 Updated by Boone Gorges 6 months ago

  • Target version changed from 1.18.7 to 1.18.8

#7 Updated by Raymond Hoh 6 months ago

  • Status changed from Assigned to Staged for Production Release

Done: https://github.com/cuny-academic-commons/cac/commit/19cc2140cb271da90450b70097914cbb9251cfc7

If the post creation date is older than one month of the current date, the groupblog post will no longer send an email to the group. I've tested this by removing the activity item of an older groupblog post and making an edit to that post in both the Block Editor and the Classic Editor and this no longer triggers an email to send.

I also tested with publishing a new groupblog post and a future groupblog post to see if a group email would still be triggered and that works as expected.

If we want to change the age threshold from one month to either a longer or shorter range, let me know.

#8 Updated by Matt Gold 6 months ago

I'm not sure that a group notification should ever be sent for an edited blog post, honestly. I would lean towards no. Luke, Boone, Laurie -- what do you think?

#9 Updated by Laurie Hurson 6 months ago

I agree with Matt - no notification for edited blog posts.

Getting additional notifications for posts could causes confusion, and people likely do not want a notification sent every time they edit.

#10 Updated by Luke Waltzer 6 months ago

I agree with Matt - no notification for edited blog posts.

+1.

#11 Updated by Raymond Hoh 6 months ago

Once this fix is live, I should clarify that you shouldn't ever receive an email for groupblog posts unless:
  • A) The activity item for the groupblog post was deleted manually from the group activity stream or did not exist previously because the post is very old (like Luke's example); and
  • B) The post creation date for the groupblog post is as recent as one month from the current date (this is the new addition)

A) should rarely occur because the activity item for the groupblog post doesn't get removed without some form of manual intervention and B) helps to prevent old posts that do not have a corresponding activity item from sending an email.

#12 Updated by Boone Gorges 5 months ago

  • Status changed from Staged for Production Release to Resolved

Also available in: Atom PDF