Edit of Post creates notification emails
I think that Bug 6350 is cropping up again. An editor of JITP edited an old post and a notification was sound out -- one showing it as getting published, the other as getting edited. Please see the notification email attached
#3 Updated by Boone Gorges 11 months ago
This is not exactly a recurrence of #6350, though the filter introduced in #6350 accidentally caused the problem in this ticket to be covered up. The workaround in #6350 was rolled back as part of #7683.
Briefly, this problem only exists for legacy posts. A number of years ago (it appears to be May 2013 or so), bp-groupblog was modified so that groupblog activity items had the type 'new_groupblog_post' rather than BP's default 'new_blog_post'. Posts created before this date (actually, most posts - some have new_groupblog_post, for reasons I don't recall) have 'new_blog_post' activity items. When bp-groupblog looks for existing groupblog activity items corresponding to the currently edited post, it looks for 'new_groupblog_post' items. As such, it misses the existence of the existing activity item, and creates a new one.
Ray - Rather than writing a kludge workaround, my inclination is do something like this:
UPDATE wp_bp_activity SET type = 'new_groupblog_post' WHERE type = 'new_blog_post' AND component = 'groups'
Can you spent 60 seconds thinking about whether this would have any weird consequences? I'm 95% sure it's safe.
#5 Updated by Boone Gorges 11 months ago
- Category name set to Group Blogs
- Status changed from Assigned to Resolved
- Target version set to 1.11.2
Thanks, Ray. I've run the query, which should fix this ticket.
I think you're right that that function is no longer needed, though to be honest, I'm unsure why it didn't prevent what Matt describes in this ticket. Not worth further investigation, I guess. https://github.com/cuny-academic-commons/cac/commit/3cccfa927d17f394500b33943ea6aebde0538c01
#9 Updated by Luke Waltzer 8 months ago
This bug has re-emerged, on this post https://jitp.commons.gc.cuny.edu/the-places-of-mentorship-and-collaboration/, triggering a notification in this group: https://commons.gc.cuny.edu/groups/journal-of-interactive-technology-and-pedagogy-public-group/