CUNY Academic Commons

Thanks all. Agreed that a simple checkbox is fine.

I mocked up putting it in a second line. IMO it becomes confusing - it seems like it's tied to the search box, and it's no longer clear that the 'Filter' and 'Reset' buttons apply to this input.

I tried a second version that involved moving the action buttons to the second row. It's not visually great but it retains the distinction between filters and action buttons.

It's also worth flagging here that my mockups in #14170 suggest making other changes to this filter interface (though perhaps not on the Courses directory) and we risk mucking up an interface that we worked hard to keep clean and easy to understand.

Thanks Boone,
Since the user has to click "filter" after they check the new "public sites" checkbox, it makes more sense to drop the action buttons below the filter options. We might want to add a 1px separator between the action buttons and the filter options so it's clear, see rough adjusted mockup attached.

Looks good to me, I like the 1px line separation.

Thanks, Sonja. Breaking the action buttons into a separate line gives us more flexibility in general, since we'll have more screen real estate to deal with. I'll see what I can do about working up a prototype.

I've built a first pass at this, and it's ready for testing on cdev. A screenshot is also attached.

Fairly substantial changes were required to make this work. Here's a rundown, for posterity:
- Group 'status' and site 'blog_public' are stored in separate tables, in a way that could not be joined as part of the course query. As such, I needed to write routines to mirror these 'public' flags to postmeta, where I could use WP's meta_query.
- Some of the mirroring routines require a switch_to_blog(), because users can change their blog_public value while on the subsite. This means registering and unregistering certain taxonomies and post types on the fly, so that course queries work (WP doesn't handle this well natively; see https://core.trac.wordpress.org/ticket/20541)
- Because of the subsite issue, I also needed to change the plugin to be 'Network: true' so that it would detect blog_public changes on subsites. A side benefit of this change is that it's now possible to fix #14437, which I've done as part of my work here.
- I've written a CLI script to fill in the 'public' postmeta for existing courses, attached here. I'll need to run this after the release.

I tried changing privacy settings for a group and a group+site, and this worked as intended. If changed to private, the result disappeared when Public Only was checked. But for this site:

https://teachtest.commons.gc.cuny.edu/

When I changed, it seemed to go private but not disappear from the results when the box is checked. See screenshot.

Hi Boone, I just set up a new public site that was NOT a teaching site, just a simple public site, "colin site to delete" at this URL added to hosts file:

https://todelete.commons.gc.cuny.edu

Then I went in and changed it to Teaching and it showed up in the Courses directory as in 1-screenshot attached. Then I changed it to private, and it still appeared with Show Public checked at the top of Newly Created, except with no links or other data as in 2-screenshot attached. Then I toggled back and see two different results, as in 3-screenshot attached.

Hi Boone, I was able to reproduce it this way, as detailed as I think I can describe:

- Created fresh new public site "delete later colin" via creation portal, campus Brooklyn and purpose Conference.
- In Settings > General, changed Purpose to Teaching, Term to Spring 2022, cluster to STEM. OER box is unchecked.
- The site now showed up in Courses as in attached 1-courses screenshot. Not sure if it should have had instructor or other lines within the item box.
- In Settings > Reading for the site, changed Site Visibility from Allow search engines... to I would like... users I add to it. Then refresh Courses, sorted by Newly Added, and two items appear as in 2-courses screenshot attached.

Left it like that for now in case you wanted to examine. Didn't want to try toggling back or complicating the sequence more.

I've run the migration script, and public courses are now showing up in the Courses directory: https://commons.gc.cuny.edu/courses/?filters%5Bkeyword%5D=&filters%5Bpublic%5D=on&order-by=semester