CUNY Academic Commons

I was only able to find three that were locked. It's probably because Luke opened them to edit, and then closed the browser window without hitting Save. See also https://github.com/boonebgorges/buddypress-docs/issues/44

Okay -- thanks

Just found another example, where I'm told that a doc is being edited by you. Please see attached screenshot.

Question: is there any way of querying the database to see which/how many docs are currently locked?

Seeing this in another group (CAC Planning) -- the email doc appears to be locked and I don't think it should be. Please see attached screenshot.

I've added Scott as a watcher. Scott, is there any chance that you clicked on the Edit mode of the Doc in question, and then left without saving (either by clicking the Back button or by closing the window)? If so, then this can be chalked up to a limitation in the way that the lock is implemented, and I'm going to move this ticket to 1.4 for a fix, as it will be substantial. If not, then it means that the lock mechanism is not even working as advertised.

Thanks, Matt.

This is not going to be done by the 1.4 release. Let's reassess after 1.4.

Just wanted to note that I'm experiencing this again in another group - http://commons.gc.cuny.edu/groups/arc-inequalities-seminar/docs/what-is-a-massive-open-online-course-mooc

I'm willing to take a look, but it's going to be a fair amount of work. WP has recently introduced a couple new features that I'd probably leverage (post locking and the heartbeat API) but it will take a good deal of research to reverse engineer those tools. I'll write it first as a feature for mainline BuddyPress Docs, and then port it back to the version that we use on the Commons.

I made some improvements for the latest version of BuddyPress Docs, and have backported them to the Commons in https://github.com/castiron/cac/commit/0363b58f223dde334b7ce70dd3f9064a75fae681

Basic edit lock functionality remains the same: only one user can edit a Doc at a time, and admins have the option of removing an edit lock manually. Otherwise, edit locks are cleared when the Doc is saved, or the user clicks out of edit mode. There is still a 30 minute "idle" window, after which you are automatically removed from Edit mode.

The main change is that a "heartbeat" detector has been introduced. While editing a Doc, your browser communicates every 15 seconds with the server. If WordPress stops receiving these pings - more specifically, if more than 4 pings are missed (one minute) - we assume that the browser window was closed or the connection was lost in some other way, and the edit lock is removed.

The combination of the existing functionality with this new heartbeat ought to catch the vast majority of cases where edit locks are being applied incorrectly.

Ready to test on cdev.gc.cuny.edu.

Boone, we just tested this and I am thrilled to say that it worked!!! Please add to the codebase for 1.6

Here's how we tested:

Micki logged in on one computer through the teststudent account, created a doc, and closed browser window while editing

I logged in to cdev and looked at the doc. it showed micki editing it, but then, after 15-20 seconds, the locked cleared.

So this is great. 2 years in the making! So glad to have this fixed. Huge thanks, Boone!!!