CUNY Academic Commons

18 is the correct count.

For some reason, there's an incorrect count of 63 in the total_member_count of the groupmeta table. I'm not sure why. I can pretty easily write a script that will correct the count for this and other groups, but I'm wary to do so before understanding why there's a mismatch. Ray, I'm swamped today, but perhaps you could find a moment to take a look and see if anything jumps out at you.

Do we think that this group should function more like the group for group admins where folks are auto added?

I leave this up to the rest of the team. I think we decided not to auto-add because we wanted to respect individual control over group memberships.

The total group member count is calculated here: https://github.com/buddypress/buddypress/blob/master/src/bp-groups/classes/class-bp-groups-group.php#L1791

When I call the groups_get_group_members() function manually for the Teaching Courses group, the returned $members['count'] is 63, but the number of members in the members array adds up to 18, so there is a bug occurring in this function. Going to do a bit more research to see what is wrong.

The issue is caused by having multiple last_activity entries for certain users.

The group member count uses the following SQL query:

SELECT COUNT(u.user_id) FROM wp_bp_activity u WHERE 1=1 AND u.component = 'members' AND u.type = 'last_activity' AND u.user_id IN (USER IDS)

For the Teaching Courses group, users 1, 49, 4203 and 10971 had multiple last_activity type entries, which caused the count to balloon from the actual group member count. See the DB query below:

mysql> SELECT u.user_id,date_recorded FROM wp_bp_activity u WHERE 1=1 AND u.component = 'members' AND u.type = 'last_activity' AND u.user_id IN (31672,37117,8864,21948,8297,12242,1510,13032,4262,7926,155,582,30020,1,34500,49,10971,4203);
+---------+---------------------+
| user_id | date_recorded       |
+---------+---------------------+
|       1 | 2022-03-11 20:26:15 |
|       1 | 2022-02-22 20:04:49 |
|       1 | 2022-03-23 20:39:27 |
|       1 | 2022-03-07 01:30:23 |
|       1 | 2022-01-07 15:46:48 |
|       1 | 2022-02-21 01:46:15 |
|       1 | 2022-02-09 01:55:43 |
|       1 | 2022-03-11 15:44:59 |
|       1 | 2021-12-21 14:00:57 |
|       1 | 2022-03-11 15:14:58 |
|       1 | 2021-11-18 16:09:42 |
|       1 | 2022-02-11 18:26:56 |
|       1 | 2022-03-09 01:59:30 |
|       1 | 2022-03-29 00:38:05 |
|       1 | 2021-12-23 18:05:58 |
|       1 | 2021-03-17 22:42:51 |
|       1 | 2021-10-22 17:59:07 |
|       1 | 2022-01-28 03:14:24 |
|       1 | 2022-01-08 18:21:29 |
|       1 | 2022-02-01 23:41:50 |
|       1 | 2021-01-12 22:05:23 |
|       1 | 2019-10-17 22:21:06 |
|       1 | 2019-08-15 01:38:46 |
|       1 | 2019-08-23 12:36:34 |
|       1 | 2019-09-05 16:42:58 |
|       1 | 2019-10-03 17:42:31 |
|       1 | 2019-10-12 16:47:04 |
|       1 | 2019-12-03 15:10:28 |
|       1 | 2019-12-20 12:31:22 |
|       1 | 2020-01-03 17:12:31 |
|       1 | 2020-07-14 22:04:04 |
|       1 | 2020-01-27 15:09:30 |
|       1 | 2020-02-04 22:29:41 |
|       1 | 2020-02-19 04:01:07 |
|       1 | 2020-02-21 00:43:49 |
|       1 | 2020-03-03 23:13:38 |
|       1 | 2020-03-15 01:19:34 |
|       1 | 2020-03-23 13:18:44 |
|       1 | 2020-03-29 18:21:59 |
|       1 | 2020-04-01 18:47:14 |
|       1 | 2020-05-07 19:41:11 |
|       1 | 2022-01-19 15:08:40 |
|      49 | 2022-03-11 19:11:17 |
|      49 | 2021-12-10 16:23:01 |
|      49 | 2022-03-30 15:26:33 |
|     155 | 2022-03-26 14:38:52 |
|     582 | 2022-03-23 18:40:01 |
|    1510 | 2022-03-30 18:33:41 |
|    4203 | 2022-03-30 19:12:38 |
|    4203 | 2022-03-30 15:36:05 |
|    4262 | 2022-03-30 18:37:00 |
|    7926 | 2022-03-29 20:08:26 |
|    8297 | 2022-03-16 18:38:27 |
|    8864 | 2022-03-30 16:31:42 |
|   10971 | 2022-03-15 16:26:42 |
|   10971 | 2022-03-29 16:17:29 |
|   12242 | 2022-03-30 17:58:16 |
|   13032 | 2022-03-30 17:32:56 |
|   21948 | 2022-03-04 20:52:18 |
|   30020 | 2022-02-09 06:50:54 |
|   31672 | 2022-03-30 15:25:21 |
|   34500 | 2021-11-01 13:46:34 |
|   37117 | 2022-03-30 14:41:03 |
+---------+---------------------+
63 rows in set (0.05 sec)

I've just removed the duplicate last_activity entries for those users and the member count for the Teaching Courses group is now correct.

To see how many other users might have duplicate 'last_activity' entries, I ran the following DB query:

select user_id,count(user_id) as DuplicateLastActivity from wp_bp_activity where type = 'last_activity' group by user_id having count(user_id) > 1;

The query returned 128 other users, so we'll also have to run a deletion routine to remove the duplicate 'last_activity' items for those users. Then we would have to recalculate the group member counts for groups that these users are a member of. sigh.

The easier workaround would be to change the count select query from COUNT( u.user_id ) to COUNT( DISTINCT u.user_id ) here:
https://github.com/buddypress/buddypress/blob/c9b0e32face9b2e028184d7dad0ffd14fee87919/src/bp-core/classes/class-bp-user-query.php#L556

But that would be hiding why (and how) the duplicate 'last_activity' entries are created in the first place.

Thanks for this, Ray. I have a vague recollection of trying to use DISTINCT when writing BP_User_Query but running into performance problems.

BuddyPress is supposed to enforce uniqueness for a user's last_activity items. See https://github.com/buddypress/buddypress/blob/c9b0e32face9b2e028184d7dad0ffd14fee87919/src/bp-core/classes/class-bp-core-user.php#L864=. There must be a bug in the routine for fetching the existing last_activity - https://github.com/buddypress/buddypress/blob/c9b0e32face9b2e028184d7dad0ffd14fee87919/src/bp-core/classes/class-bp-core-user.php#L803=

Maybe we could set up a routine for detecting these dupes? We could hook into bp_core_user_updated_last_activity and detect whether the just-updated user has multiple entries, and if so, record the stack trace. This might help to narrow down the issue.

Ray, do you agree?

Yeah, let's do option 3 for now. Thanks Boone!