CUNY Academic Commons

Ray, could you spend a minute looking at this? I think that, as described in your GitHub ticket, this is a case where the event is corrupted in the DB, so I'm wary of putting a bandaid over it.

I think this is related to the Advanced Post Cache plugin we are using on production. On production, I've temporarily added some code to exclude the 'event' post type from the Advanced Post Cache plugin in this existing callback filter: https://github.com/cuny-academic-commons/cac/blob/759c8c2fa85f48f449bde8ebdb2bb0b39c4a78c8/wp-content/mu-plugins/cac-functions.php#L3286.

Since I've added the code and after refreshing the sample AJAX request URL about a dozen times, I haven't been able to trigger the fatal error. Once I get some confirmation that this is working for others, I'll commit the fix.

I haven't been able to reproduce this now, either. Scott, does it seem fixed to you?

Hi Colin - I no longer get the fatal error. But when I switch to calendar view and go to December (where there are a lot of events) and then switch to List view I get taken back to January events. I was hoping to take a screenshot of the list view when there are a lot of events.

Thanks for testing, Colin and Scott. I've committed the fix for the event calendar AJAX problem: https://github.com/cuny-academic-commons/cac/commit/96296f4c392005163f4fed5db5e0b989f40696e9 .

I'll let Boone handle the list view issue that Scott mentioned in comment 4. I also noticed some bugs with recurring events. See #17587.

Thanks for having a look, Ray.

Hi Colin - I no longer get the fatal error. But when I switch to calendar view and go to December (where there are a lot of events) and then switch to List view I get taken back to January events. I was hoping to take a screenshot of the list view when there are a lot of events.

List view only shows upcoming events. There's no way to view a previous month's events in list view. This is a limitation of how Event Organiser works.

List view only shows upcoming events. There's no way to view a previous month's events in list view. This is a limitation of how Event Organiser works.

It looks like it is possible to view previous month's events in list view. Event Organiser has an archive view and when using the following permalink, you can view all 2022 events: /events/event/on/2022/. For monthly permalinks such as December 2022: /events/event/on/2022/12/. We just need to style the event archive template to resemble our list view and and expose some type of monthly pagination. What might complicate things is our custom scope filters for campus events, featured events and the current user's events.

Will see what is possible.

Thanks for looking into this, Ray.

Likewise, I think the counts for "All Events" and "My Events" are confusing because those counts encompass all events ever created. I would probably recommend removing the counts entirely as I'm not sure if the count has any utility.

I agree with this.

The navigation flow with your changes doesn't feel quite right to me. When you land on https://commons.gc.cuny.edu/events/, you see the Upcoming Events List view. If you toggle to Calendar, you see February 2023. If you then toggle back to List, you are now seeing February 2023 instead of Upcoming, and there's no way to get back to Upcoming.

IMHO, we don't want to lose access an at-a-glance list view of upcoming events, one that is not tied to a month. (1) Users browsing Events are probably more likely to be interested in future events than past ones. (2) Say it's February 26 and you go the list view. If it's linked to the month, you'll have to scroll through Feb 1-25 to get to upcoming events, and then you'll only see a few days' worth.

It would be nice to hear what Sara and Colin have to think about a list view for past events. I'm not personally convinced that it's necessary. The original problem in this ticket is that there was some confusion about the different behavior of Calendar vs List, but I wonder whether we can solve this with better labelling (changing "List" to "Upcoming" perhaps) instead of a functional change to list view.

The navigation flow with your changes doesn't feel quite right to me.

Yeah I was thinking the same thing last night, but Scott's problem from comment 4 is an important flow question that we need to solve as well.

I had this thought when I woke up that the nav should change to the following:

• All Upcoming Events (is currently All Events)
• My Upcoming Events (is currently My Events)
• Calendar (new nav item) (Could be renamed to something else like "Monthly Events" or "View by month"). This would default to the calendar view and would solve most of the flow issues you mention above.

In "All Upcoming Events" and "My Upcoming Events", we remove the List View and Calendar View icon buttons displayed on the right. The Calendar View icon button doesn't make much sense on these pages as it is just a calendar and has buttons to view older and future months. Having a dedicated "Calendar" nav item would solve the issue and would retain the List View and Calendar View icon buttons.

What does everyone think?

I wonder whether we can solve this with better labelling (changing "List" to "Upcoming" perhaps) instead of a functional change to list view.

This would also solve Scott's problem. The "List" button right now on production is doing double duty as an Upcoming Events list, so that's where the confusion lies although I do see the utility of having a monthly list view.

I'm adding Matt as a watcher here, because we discussed this during the Friday dev call and I'm not sure if I'm going to transfer his feedback correctly (I think one or two of the latest thread updates came in after that conversation, also).

I like Ray's idea about changing nav labeling, both easier than changing functionality and perhaps more clear. I wonder if we can go with "All Upcoming" and "My Upcoming" and drop the extra "Events" appendages, especially since Events is the header label and you know you're already on the Events page. "Calendar" works for me as the third label, but I could also see something like "Grid View" or "Event Grid."

Would it also help, regarding the prior events issue/desire we've discussed, to simply add arrows at the bottom where relevant for "Previous Events" and "Next Events" kind of like in this similar view (which I think is using a similar plugin setup as ours)?

https://www.green-wood.com/calendar/photo/

I guess in our case right now we'd only have a "Previous Events" arrow, taking one back in the list view as that link does, and when we're more populated with upcoming events we'd have the Next Events link appear when we hit our max display number for the main Events page.

On cdev, I've made changes to the event navigation and also fixed the following bugs:

• Fixed "All Upcoming" and "My Upcoming" event count to only use upcoming events for the count, as well as including recurring events
• Fixed "My Upcoming" page to include your upcoming group events
• Fixed event date and time display on single event pages. Was previously displaying "January 1, 1970".

I guess in our case right now we'd only have a "Previous Events" arrow, taking one back in the list view as that link does, and when we're more populated with upcoming events we'd have the Next Events link appear when we hit our max display number for the main Events page.

It might be possible to do something about this in list view, however it's worthwhile to note that we already have two types of pagination:

1. In either Upcoming or Calendar List view, if there are more than 10 events on a page, there will be a pagination block displayed at the bottom. (Side note: We currently display four events per row. Should we change the pagination to 12 or 16 so the list view is uniform?). If we were to include the "Previous Events" arrow, would we have two sets of pagination at the bottom?
2. If you are in calendar list view, the date header on this page has arrows to go to the previous month or the next month. Right now, if you click on the previous month arrow, it will just go back one month sequentially even if that month has no events. Perhaps the previous arrow should traverse to the previous month that has events instead?

Hi Ray, thanks for thinking through these nav and pagination issues. It seems to me that we should definitely change the 10 default list items across 4-wide rows. I'm thinking 16 to balance it all out.

For pagination, what if it's just Previous Events and Next Events at the bottom? I don't see people getting a lot of utility out of the current numbered pagination options for skipping ahead, anyway.

On the date header, I think it would be confusing if you click the previous month header and don't go back sequentially, but instead hop way back to a month with populated events. Hopefully this won't be as much of an issue once we have events being added more regularly though, and we'll have at least something archived for every month.

Let's also remove the "location" line item from the tiles on list view (I think it's already not showing on calendar view?), so it isn't confusing as we discussed in the dev call whether this line means campus affiliation or actual location. That is more clear to see in the single event full view.