Feature #2800
closed
- Assignee changed from Boone Gorges to Dominic Giglio
- Target version set to 1.5.4
Dom, could I ask you to have a look at this? You did it in the past for academia.edu. Reference: #2248
Yup, I'll start looking into this today. If I remember correctly, you're plugin design made it incredibly simple to add new fields. Kind of like a plug-and-play situation. Shouldn't have any problem getting this into 1.5.4 and off the list.
- Target version changed from 1.5.4 to 1.5.5
- Target version changed from 1.5.5 to 1.5.6
Boone,
The last time we worked on an issue like this, you asked me to handle it in two separate steps:
1.) Updated a forked version of the official Github repo and issue pull-requests for changes
2.) Update CAC repo with the same changes once you've verified
I've completed step one and submitted pull requests for both Vimeo and Github profile link support. For some reason my local env profiles are not working. I have no idea why - as soon as you released the new profiles in 1.5 and I switched to 1.5.x for mainline dev my profiles worked perfectly. Now all I see is the original commons profile page. And sometimes the toolbar disappears when I view my /members/humanshell page locally. This is all locally, the production site looks fine.
So, if you have time, could you please check and make sure these new profile fields work in your local env? As soon as you verify I can add the code to the plugin in our repo and release it. Not sure how I'm going to figure out my local issues but I'm sure I'll find the problem eventually.
I'm bumping to 1.5.6 so we both have time to integrate the new fields properly.
Hi Dom -
Thanks for this! The pull requests look good, and are integrating nicely in my local dev environment.
Small note about images. On the Commons, we're using a different set of social media icons than those available in the Github plugin. It so happens that this set does provide icons for Github and Vimeo, so I think we're set, but the Github icon is (sadly) a lower-case 'g' rather than the Octocat.
Not sure why your local stuff isn't working. Try git submodule update --recursive to see if that helps.
- Status changed from Assigned to Resolved
I think this is good to go, so I'm marking resolved. Thanks, Dom.
I completely forgot that in our repo we're pulling from a different set of images. I do remember having a similar discussion when I added academia.edu. Glad it's all setup and working, I'll remember about the images if I continue on with the profiles in issue #2613.
The command above didn't help. Maybe you and I can spend a few minutes looking at my local env before or after (or during) Friday's meeting? There is another issue I'd like to discuss with you that is only a problem for me locally.
Sure, we can look at it on Friday.
Also available in: Atom
PDF