Project

General

Profile

Bug #411

Hero JS not working on IE(7)

Added by Boone Gorges almost 11 years ago. Updated almost 11 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
BuddyPress (misc)
Target version:
Start date:
2010-11-23
Due date:
% Done:

0%

Estimated time:

Description

See #366. I haven't verified the issue on other versions of IE or Windows.

Could someone with a proper Windows testing environment please test (the changes are live on cdev)? Does the current hero slider work on IE?


Related issues

Related to CUNY Academic Commons - Bug #373: Text not showing in Hero slider in ie6 and 7Resolved2010-10-22

History

#1 Updated by Ron Rennick almost 11 years ago

I just checked it in IE8 and there is an error in the javascript, but it might be with any of the js on the page. Once IE hits the error, it stops processing.

#2 Updated by Boone Gorges almost 11 years ago

Aha. Do you have a better method of troubleshooting than just disabling scripts to find the culprit?

#3 Updated by Ron Rennick almost 11 years ago

Not with IE. Even with version 8, I'm not sure there is much in the way of tools for debugging (other than maybe visual studio).

#4 Updated by Boone Gorges almost 11 years ago

OK. I'll try hammering at it after I've built up some of the patience I lost this AM :)

#5 Updated by Boone Gorges almost 11 years ago

  • Status changed from New to Resolved
  • Assignee set to Boone Gorges

Gah, IE is really a nightmare.

Something is causing IE to stop rendering before it completes the document, so on the home page it never gets to (document).ready. That's why the post gallery stuff wasn't firing. I combed through and tried shutting stuff off but I couldn't figure out the problem for the life of me. So here's the hack: I'm commenting out the jQuery(document).ready stuff and just firing the jQuery cycle code as soon as it's loaded. Since the JS is loaded in the footer, it shouldn't be a problem - the elements already exist in the DOM by that point.

I also had to add some terrible CSS to make the hero and the footer look right in IE. Marking this as resolved because I don't ever want to think about it again :)

#7 Updated by Matt Gold almost 11 years ago

Yikes. I will buy you a beer for this one.

Also available in: Atom PDF