Bug #5069
closed
Comments visible in edit mode
Added by Samantha Raddatz over 8 years ago.
Updated about 8 years ago.
Category name:
Social Paper
Description
While exploring ticket #5051, I came across a strange state where I can view the comments on my paper while in edit-mode. While I think it would be great if this was possible, I don't think it's intentional so I wanted to bring it to your attention.
Here's how I got to it:
- Using Chrome, logged in, went to Papers tab to access the full directory
- Clicked on my paper in the 'All Papers' tab of the directory
- That took me to my own paper in edit-mode with the comment bubbles visible. Clicking on the + or trying to reply to an existing comment does not function correctly.
- I had to clear my cache to re-create this. Once you've opened the paper once, the same sequence of steps brings you to the paper in read-mode immediately.
Screenshot of the comments visible during edit-mode attached.
Files
- Target version set to 1.9.4
- Assignee changed from Boone Gorges to Raymond Hoh
Ray, you have any idea why this would be happening? I don't see how Edit mode would be triggered on entry like this.
- Target version changed from 1.9.4 to 1.9.5
- Target version changed from 1.9.5 to 1.9.6
- Status changed from New to Reporter Feedback
It might have something to do with HTTPS and the hotfix we deployed for FEE:
https://github.com/cuny-academic-commons/cac/commit/7550ae6e1835fb87fbf7ecda757819e28ded4688
But, like Boone, I could not duplicate this with Sam's instructions. Specifically:
- Clicked on my paper in the 'All Papers' tab of the directory
- That took me to my own paper in edit-mode with the comment bubbles visible.
If you click on a link from the Papers Directory, it shouldn't take you directly to Edit Mode.
Is this still happening on production?
- Assignee changed from Raymond Hoh to Samantha Raddatz
- Target version changed from 1.9.6 to 1.9.7
I just re-tried my steps on the dev and it does not appear to happen on cdev, though it's still happening on the live-site.
- Status changed from Reporter Feedback to Resolved
- Assignee changed from Samantha Raddatz to Raymond Hoh
Okay, I was finally able to duplicate this bug locally and have added a fix for this:
https://github.com/cuny-academic-commons/cac/commit/6a9cfa129076fa8a9229588d1ac33f277390dd7c
Previously, we appended #edit=true to the paper URL if you were viewing the site without SSL. This would trigger edit mode automatically when clicking on a paper link.
Now, if you click on a paper from the Papers Directory, edit mode will no longer be triggered, which is what we intended originally.
Also available in: Atom
PDF
