CUNY Academic Commons

bbPress 2.6 was released last week: https://bbpress.org/blog/2019/11/bbpress-2-6/

Per our regular procedures, this means that we'll be upgrading as part of the 1.16.2 release in late December. The bbPress update is large, and we have made a number of important modifications to bbPress's default behavior in order to be compatible with the Commons setup (#10654, #9003, #5133, #5318, probably others). Before releasing to the Commons, we should do some sanity checks to ensure the following:

1. Existing BP group forums continue to be associated properly with their groups
2. New groups can properly be associated with group forums
3. The following fixes are still working (these are the customizations that look to be functionally important):
a. https://github.com/cuny-academic-commons/cac/blob/0a4d0b658d243ac78bd850b79cd0a0cff2630c1c/wp-content/plugins/cac-bp-custom-includes/forums.php#L17,
b. https://github.com/cuny-academic-commons/cac/blob/0a4d0b658d243ac78bd850b79cd0a0cff2630c1c/wp-content/plugins/cac-bp-custom-includes/forums.php#L82 (actually that one may not be necessary after recent changes in group creation)
c. https://github.com/cuny-academic-commons/cac/blob/0a4d0b658d243ac78bd850b79cd0a0cff2630c1c/wp-content/plugins/cac-bp-custom-includes/forums.php#L206 #3649
d. https://github.com/cuny-academic-commons/cac/blob/0a4d0b658d243ac78bd850b79cd0a0cff2630c1c/wp-content/plugins/cac-bp-custom-includes/forums.php#L250 and the following function
e. https://github.com/cuny-academic-commons/cac/blob/0a4d0b658d243ac78bd850b79cd0a0cff2630c1c/wp-content/plugins/cac-bp-custom-includes/forums.php#L315 #4734
f. https://github.com/cuny-academic-commons/cac/blob/0a4d0b658d243ac78bd850b79cd0a0cff2630c1c/wp-content/plugins/cac-bp-custom-includes/forums.php#L326 and following function
g. https://github.com/cuny-academic-commons/cac/blob/0a4d0b658d243ac78bd850b79cd0a0cff2630c1c/wp-content/plugins/cac-bp-custom-includes/forums.php#L492
4. The inline comments say that https://github.com/cuny-academic-commons/cac/blob/0a4d0b658d243ac78bd850b79cd0a0cff2630c1c/wp-content/plugins/cac-bp-custom-includes/forums.php#L402 can be removed after the 2.6 upgrade

Ray, I'm copying you here because you've been my spiritual partner in these journeys through the bowels of bbPress. I was hoping you could look in particular at 4, and maybe a sanity check on 1 and 2. There are some more items in the cac-bp-custom-includes/forums.php file that are less mission-critical (like TinyMCE and mentions support) that you wrote but which I excluded from this list; if you have the bandwidth to verify those too, it'd be helpful. Otherwise I'll review the items in 3, which are mostly my doing.