CUNY Academic Commons

Boone, I took a closer look at GES and it looks like the post type exists check defaults to false when installing the email templates: https://github.com/boonebgorges/buddypress-group-email-subscription/blob/d322c0bfb053b9ee23d1e25a250717d1e506313a/admin.php#L386. Since ass_install_emails() is hooked to 'bp_core_install_emails', it runs whenever BuddyPress (or another plugin) calls bp_core_install_emails(). BuddyPress has used this function in their updater over the past couple of major releases, which has resulted in the duplicate GES email templates.

I've added a PR for your review here: https://github.com/boonebgorges/buddypress-group-email-subscription/pull/221

Just adding Boone and Matt as watchers here to make sure we get the right eyes reviewing this for you Ray before we move ahead. Thanks!

I've merged the PR in the BPGES repo. Ray, should I do a BPGES release, or can we apply this directly to the Commons?

It would be good to do a general BPGES release before the next major BuddyPress release, but for our purposes, we can patch our current version of BPGES now. I'll patch up BPGES later today.

Sounds good - I'm going to open a separate ticket so I don't forget to release BPGES in the upcoming weeks.