Bug #1829
closed'No Image' checkbox on Featured Content widget is not working
0%
Description
Just tried to feature Brian's latest Round Up post but the "no image" checkbox didn't have an effect -- a huge image showed up in the widget, displacing content on the page.
So, I'm wondering about a few things:
-- Is there a specific problem with the "no image" checkbox, something where it was working previously but isn't now? Maybe it has something to do with bug 1685 ?
-- Do we have a central ticket where featured content widget issues are centralized? I'd really like us to make some fixes in the near term, if possible, since I have so many problems featuring content on the site and it's just so visible on the homepage . . . . I know we are going to go through a redesign process, but I think that if it wouldn't take up too much time, some work on this would really be warranted. Thoughts?
Related issues
Updated by Boone Gorges over 12 years ago
- Subject changed from Featured Content Issues to 'No Image' checkbox on Featured Content widget is not working
- Assignee changed from Boone Gorges to Dominic Giglio
- Priority name changed from Normal to High
Do we have a central ticket where featured content widget issues are centralized?
No, but #1453 has a list of some items that you want fixed.
Dom, can I ask you to move this item to the top of your list of priorities? If you think it would be helpful to talk over the issues, or if you need a more detailed description of the problems than what's listed here and in #1453, please let me know and we can talk about it.
Updated by Dominic Giglio over 12 years ago
I have no problem moving this to the top of my list. I'll let you know if I have any specific questions.
Updated by Dominic Giglio over 12 years ago
Boone,
In our subcommittee meeting you basically said we have two choices for this plugin, spend time debugging and patching, or use that time to rewrite the plugin. I was going to go with the former at first, but after spending a little more time in the code, I now believe that the latter would be the correct way to go. This plugin isn't an internal portion of the CAC site, it's a plugin that stands on its own and therefore deserves far more attention then just some patching to "make it work." I think this plugin has tremendous potential to be beneficial to any BuddyPress/MutliSite install, but not without a complete rewrite.
I've already got a tremendous amount of the rewrite done. I started coding on Friday when I got home and haven't been able to stop. But, before I fill you in on all the gory details, I am curious about Matt's question above: Should I create a kind of "meta ticket" where you and I (and anyone else interested) can centralize the discussion about all the issues with this plugin?
Let me know what you think.
Updated by Boone Gorges over 12 years ago
Hi Dom. OK, that sounds good. You don't need to open a meta ticket for my sake, but if you think it'll help you to have a single ticket that consolidates all the issues, be my guest.
I'll be interested to see what you've come up with.
Updated by Boone Gorges over 12 years ago
- Status changed from Assigned to Rejected
- Target version deleted (
1.4)
I'm closing this ticket, with the expectation that it will work under the rewrite described in #1871.
Updated by Boone Gorges over 12 years ago
Updated by Dominic Giglio over 12 years ago
No worries, what I meant by my comment was that this ticket should be closed if the issue described gets fixed in #1871. As far as my local testing goes, I think the no image checkbox functionality works fine. I will only reopen this ticket if testing on cdev uncovers a bug in that part of the code. Otherwise, I'm fine with this ticket being closed.