CUNY Academic Commons

If you are not a member, the link to register at the bottom just goes to the general registration form. Presumably, after one registers, the invite is waiting in your inbox, but I didn't test that yet.

Yes, it goes to the registration page, but the URL should have claim_key and invitation_id parameters. These are used to ensure that the registration is linked to the invitation, and the group/site invites are sent after you activate your account.

- The copy here can probably be condensed. First though, where we say this: "To change the people you are inviting or the groups and sites to which you're inviting them, click the edit link for that area." Where is the edit link? I can't seem to find it on production. We do have a Back button so you can go back and alter.

The links are there, but they're white. The color was inadvertently changed in a recent redesign-related release, when some CSS for another part of the site change the link color here too.

- For this line at the end: "Clicking 'submit' will send an email to all invitees and add notifications on the Commons for any existing members." I take it that by "invitees" we mean anyone who isn't already a Commons member, right? I might try to clarify that language if so.

No, everyone gets an email, members and non-members. I agree this could use some rewording, though. Maybe: "Clicking submit will send an email to all invitees. Existing Commons members will additionally receive a notification about their invitations." Or we could even scratch the bit about notifications - I'm not sure it's salient for the sender.

- Does the above quoted line also mean that email is only generated when the invite request includes someone who isn't already a Commons member? This might complicate offering an option to get a carbon copy of your sent invite. Otherwise though, is there a tech limitation on including a checkbox at the bottom for "Please email me a copy of this invite request." or similar?

There's no technical limitation with adding a checkbox. The limitation is that different recipients receive different emails, so there's not a single "invite request" to CC. Members receive different text from non-members. And if you include someone in the list that is already a member of the Commons and is already a member of the group in question, then they don't receive anything at all. Put differently: Clicking submit sends multiple invitations, not a single one, and the most straightforward way to implement CC would be to CC each individual invitation.

I took a stab at updating the copy for the model panels in this Google Doc. Feel free to jump in and suggest any changes. Otherwise, perhaps Sara you can add this text for your next round of revisions to this?

https://docs.google.com/document/d/1ZSnQ06va3yufy3H4Y9_RDY0BgjTBoK-5LKtP0egRmew/edit?usp=sharing

Regarding a checkbox to CC the person doing the inviting, given what Boone said above about the multiple invitations at play and needing to potentially send a CC for each individual invitation in order to enable this, I'm thinking it's more trouble than it's worth.

Thanks Sara, looks great, and looking forward to going over this with the group tomorrow. A couple very small things I noticed, not necessary for tomorrow:

- Panel 2 title should be Groups/Sites, not Invite
- Remove the "Send me a copy" checkbox and text on Panel 3
- On Panel 4, should the two buttons/columns be centered? Alignment seems a little off to me, just a thought.

Sara, could you please give me a rendered version of the confetti graphic? In Figma it's cut into a bunch of pieces and I'm not sure the best way to flatten it.

I've taken a first pass at the reskin of the invitation modal, but it doesn't look quite right yet on group pages. This is because the shared.css stylesheet isn't yet loaded there. I'm going to let Ray do his magic on the group pages before touching it.

In the meantime, you can test using the invitation modal on your own Invites page on cdev. I don't know how you get there through the interface (did we remove all links?) but you can visit directly: http://commons.gc.cuny.edu/members/[yourusername]/invites. Then click 'Invite Members'.

Sara, a few implementation notes and questions for you:

a. The comp shows a down arrow in the 'By Name' box. But this is not a select box, it's a type-ahead. So there's nothing that the down arrow could do. I've left it out.
b. I added a highlight/hover state for the 'By Name' selector dropdown. Actually, I just left in place what was already in the plugin :-D
c. The comp shows that only the outline of the By Email field is highlighted when there's an error. But this glosses over some of the fine-grained error-checking of the plugin. Namely, if you enter multiple email addresses, only some of which are invalid, then only the invalid ones are highlighted in red. As such, I've added the red border color, but left the red-text highlighting.
d. Seems like the aspect ratio of the 'Next' button is slightly different from other buttons in Commons interface. I have tried to match the comp, but I wanted to bring this up in case you wanted to cross-referenc.
e. The comp doesn't show a vertical scroll bar for group/sites lists on step 2, but it seems important, particularly on desktop. I've added it.
f. The comps for different pages differ somewhat regarding the space below the nav, as well as the space following the intro paragraph below the nav. I've adjusted them so that they're roughly the same.
g. I've left empty spaces on the Review panel when there's no avatar. This happens in the case of (most?) sites, as well as invites by email address.
h. I took some guesses about how mobile styling should work. Take particular notice of how I stacked the tab navigation.
i. We briefly discussed that the nav items should be clickable, this doesn't really make sense when you're moving in the forward direction. For example, you shouldn't be able to skip to step 3 when you haven't filled out step 1 or 2. As such, I've made previous steps only clickable in the nav tabs.
j. The confirmation screen doesn't have the confetti yet. I'll put this in place when I get the asset from you.

Thanks, Sara! I've added the confetti image. I set it to background-size: cover, so it's not precisely positioned at all sizes, but I think it's legible as I resize the screen.

This is looking great!

d. Seems like the aspect ratio of the 'Next' button is slightly different from other buttons in Commons interface. I have tried to match the comp, but I wanted to bring this up in case you wanted to cross-referenc. -- Interesting, I will take a look

g. I've left empty spaces on the Review panel when there's no avatar. This happens in the case of (most?) sites, as well as invites by email address. -- I'm not sure how I feel about this. Would we want to use default avatars?

h. I took some guesses about how mobile styling should work. Take particular notice of how I stacked the tab navigation. -- Looking great

Styling notes:
- The error text needs to be in the Poppins sans serif
- the "back" link needs to be the darker A11y friendly blue #367BA3 and underlined

Thanks for having a look!

g. I've left empty spaces on the Review panel when there's no avatar. This happens in the case of (most?) sites, as well as invites by email address. -- I'm not sure how I feel about this. Would we want to use default avatars?

Yes, we can do that. I've made the change.

- The error text needs to be in the Poppins sans serif
- the "back" link needs to be the darker A11y friendly blue #367BA3 and underlined

I've made these changes too.

Thanks, Colin. I'm not seeing what you're seeing. Are you sure you're accessing this via commons.gc.cuny.edu/members/[yourname]/invites? As noted above, the global styling is not yet available when testing from groups.

My apologies, Boone. As you suspected, I missed that part about the proper link for testing. It looks fine to me at that link now. Do we need some sort of inventory of the various places one can access the invite modal, or will that take care of itself once we do the full rollout?

Do we need some sort of inventory of the various places one can access the invite modal, or will that take care of itself once we do the full rollout?

The group interface should look fine once the groups inherit the redesign styling. But yes, it makes sense to do a quick check from the various interfaces. The plugin was intended to support several different launch points:

1. 'Send Invites' nav menu item when visiting a group
2. The 'Invite New Members' button on commons.gc.cuny.edu/members/[yourname]/invites
3. Users > Add New User when viewing the dashboard of a site

I'm not sure that 2 is accessible via navigation since the rework of our profiles.

Anyway, as we get closer, we should be sure to test that the modal can still be accessed and still looks right via all three of these paths.

Thanks Boone, this sounds good to me, and I can make a note of it for testing.

In the Friday meeting, we decided it would be good if possible to add an "X" or close-out option at the top of the congratulations screen to close the modal and take you back to whatever page you were on when you opened it to send invites.

Added in https://github.com/cuny-academic-commons/cac-onboarding/commit/bfb79d09696efea0c783842c29a56c23e70976d2

Good catch. This is being caused by the API returning URLs with HTML-encoded characters. When feeding them directly from the API response into the Vue.js component, they were being double-escaped. This bug has likely existed since the feature was introduced. Should be fixed in https://github.com/cuny-academic-commons/cac-onboarding/commit/02332b67c04d55ee7515559c8a87134db57b8ecc

I was testing Ray's updated site creation design in #20426, and the invite modal on the congrats screen at the end is the old version. Can we update this to match the new modal we've tied to the group invite flows?

I was testing Ray's updated site creation design in #20426, and the invite modal on the congrats screen at the end is the old version. Can we update this to match the new modal we've tied to the group invite flows?

Hm, I'm not able to reproduce this on cdev. The "old" version doesn't exist anywhere on cdev - the old styles have been replaced. Is there a chance your browser is caching something from the production site (which is, of course, running the "old" styles)?

Sorry about the false alarm here, please disregard. I just tried again and wasn't able to reproduce this, either. Not sure what I was doing before.