Project

General

Profile

Actions

Bug #20861

closed

Unread notifications for invites I didn't send

Added by Colin McDonald 3 months ago. Updated 3 months ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Group Invitations
Target version:
Start date:
2024-08-30
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

See attached - wondering if it's expected behavior that Notifications > Unread seems to be showing all accepted invites for a Teaching group for which I'm an admin. Shouldn't it only show accepted invites that I sent, or if it's going to show them all, say "X accepted an invite to the group" instead of "X accepted your invite to the group"?


Files

invites unread.png (250 KB) invites unread.png Colin McDonald, 2024-08-30 10:51 AM

Related issues

Related to CUNY Academic Commons - Bug #20921: "The Group for Group Admins" auto-invite should use our custom invites systemNew2024-09-10

Actions
Actions #1

Updated by Raymond Hoh 3 months ago

Hi Colin,

it's expected behavior that Notifications > Unread seems to be showing all accepted invites for a Teaching group for which I'm an admin

It's expected that the inviter should receive a notification whenever a user accepts an invite.

Shouldn't it only show accepted invites that I sent

It looks like we have set up an auto-invite to send out whenever a group that is connected to a course is created: https://redmine.gc.cuny.edu/issues/14777#note-17 . Since you are the first admin of the "Teaching Courses on the Commons" group, the invite will be sent out from your account: https://github.com/cuny-academic-commons/cac/commit/caf367e56c776ff5dba26fa8299defa177160f55#diff-e199d5f24d983e8d01b0190e1d59fc65c9cd3659c2841dd6664a47fdd4469f00R2991 . Invitation notifications were a recent addition as a part of the Commons Profile redesign back in v2.2.0. If these notifications are a bother, Colin, perhaps we can look to suppress these auto-invite accept notifications for you.

Actions #2

Updated by Colin McDonald 3 months ago

Hi Ray, thanks for the clarification here. Just making sure I follow -- every time someone sets up a Group (and/or a Site?) with the purpose marked as Teaching, it is identified as a Course and the person who did the setup is automatically invited (I assume if they're not already a member) to the Group called Teaching Courses on the Commons?

Then it shows up in my notifications, because I technically sent the invite as the default or first admin of that Group.

If that's all correct, I don't mind the notifications, but that better explains their origin and why the invites are explained as coming from me. I guess there aren't many other (any?) auto-invites to groups being sent out on the Commons.

Actions #3

Updated by Raymond Hoh 3 months ago

  • Category name set to Group Invitations
  • Status changed from New to Staged for Production Release
  • Target version set to 2.4.6

Just making sure I follow -- every time someone sets up a Group (and/or a Site?) with the purpose marked as Teaching, it is identified as a Course and the person who did the setup is automatically invited (I assume if they're not already a member) to the Group called Teaching Courses on the Commons?

Then it shows up in my notifications, because I technically sent the invite as the default or first admin of that Group.

That's correct, Colin.

If that's all correct, I don't mind the notifications, but that better explains their origin and why the invites are explained as coming from me.

We talked on the call to move the inviter from Colin to the group's creator, Laurie. This is done in https://github.com/cuny-academic-commons/cac/commit/4f55b65098347673cb471ec22deef12ea46d95ab.

I guess there aren't many other (any?) auto-invites to groups being sent out on the Commons.

We have one other group auto-invite to "The Groups for Group Admins" group. However after looking into the code for how that invite is sent out, it either needs to be updated to account for new changes to the BuddyPress invites system or preferably, we should switch to using our custom invites system that we are currently using and built back in #8641. I'll create a new ticket for this. Update: See #20921.

Actions #4

Updated by Raymond Hoh 3 months ago

  • Related to Bug #20921: "The Group for Group Admins" auto-invite should use our custom invites system added
Actions #5

Updated by Boone Gorges 3 months ago

  • Status changed from Staged for Production Release to Resolved
Actions

Also available in: Atom PDF