Feature #2243
closed
Setup chasefrobinson Theme as a Luna Child Theme.
Added by Dominic Giglio over 11 years ago.
Updated over 11 years ago.
Category name:
WordPress (misc)
Description
The Provost site: http://chasefrobinson.commons.gc.cuny.edu/ is currently installed as a customized version of the Luna theme. To improve development moving forward we should implement the theme as a child of Luna. This will allow us to more easily update the core Luna parent without having to worry about breaking custom features.
Thanks, Dom. Added Erin as a watcher on this.
Thanks, I shoulda remembered to add Erin. :-)
I've added the new luna-cfr child theme to our repo, so it will be included in the 1.4.10 release. I started our customizations off with a functions.php file in our child that deregisters the parent's version of fadeslide.js and registers the customized version that forces the slider to start on page load. This was actually what started me off thinking about a parent vs child setup. I figured if we were going to be making more edits like this we needed to move to a child sooner rather than later. The update to 1.9 would have overridden our custom js.
I've also added a reminder to ACTION_REQUIRED to enable this child for chasefrobinson.
I think we'll be able to close this issue out tonight just like #2242. As soon as I verify the site is behaving appropriately.
Commit: https://github.com/castiron/cac/commit/447477a3ee5bf3e51be0df456627389d77ad60ed
Fantastic. Thanks, Dom! Can I ask you to email all child theme files you've created to Erin so that she can study what you've done? Many thanks.
No rush on that emailing, btw. At your convenience.
Dom, I've enabled (but not activated) the theme on the Provost blog.
- Status changed from Assigned to Resolved
Thanks Boone.
I've activated and verified that we are GODD TO GO!! Child theme operating as expected and slider begins on initial page load.
The only thing I had to update was the Primary Menu. But I knew I was gonna have to do that.
Closing issue.
Awesome work, Dom! Many thanks.
Also available in: Atom
PDF