Project

General

Profile

Actions

Bug #4636

closed

Silent edit option for editing forum posts

Added by Matt Gold about 7 years ago. Updated about 7 years ago.

Status:
Resolved
Priority name:
Normal
Assignee:
Category name:
Group Forums
Target version:
Start date:
2015-09-20
Due date:
% Done:

0%

Estimated time:
Deployment actions:

Description

I edited a post earlier tonight, and it created a separate email notification to the entire group. Is this expected behavior? I don't think this should be the default behavior, as it creates two emails in a row about the same post. At the least, I think we should give people an option to do a "silent edit" that does not create an email notification.

If we create a "silent" option, we should still leave an indication that the post was edited from its original form -- we should probably follow the practice of message boards, which often leave a note like "[user] edited this post on [timestamp]"


Related issues

Related to CUNY Academic Commons - Feature #4676: Offer silent option (no email notification) for events calendar in groupsResolvedDaniel Jones2015-09-25

Actions
Actions #1

Updated by Boone Gorges about 7 years ago

  • Assignee changed from Boone Gorges to Daniel Jones
  • Target version set to 1.9

Matt - Yes, this is expected behavior.

Dan, could you have a look at this for 1.9? See the Docs editing interface for some language and UX you can borrow. You'll need to intercept bbPress before it creates a BP activity item, and prevent that activity item from being created. It's probably as simple as a `remove_action()` call :)

Actions #2

Updated by Boone Gorges about 7 years ago

  • Target version changed from 1.9 to 1.10
Actions #3

Updated by Raymond Hoh about 7 years ago

  • Status changed from Assigned to Resolved
  • Assignee changed from Daniel Jones to Raymond Hoh
  • Target version changed from 1.10 to 1.8.18

I edited a post earlier tonight, and it created a separate email notification to the entire group. Is this expected behavior?

I just encountered this on the Commons while editing a forum post.

This is not expected behavior. Also see #3941 and #4072.

Long story short, this is a bbPress bug with a fix that is scheduled for bbPress 2.6.0; bbPress is currently at v2.5.8. We forgot to add our fix to bbPress when it was updated to 2.5.8.

To avoid having to modify bbPress every time until bbPress 2.6.0 is released, I've added a fix that is no longer reliant on hacking bbPress.

See commit 690ff30.

Marking as resolved. This fix should be added on December 1st.

Actions #4

Updated by Matt Gold about 7 years ago

Thanks very much for this, Ray.

Actions

Also available in: Atom PDF