CUNY Academic Commons

Can you give me a sense of what this might look like, beyond mere copy-and-paste?

Adding Chris and Michael as watchers as this needs some UX love.

This would require creating an option to "reply with quote" for each post in a forum thread. This would have to be in addition to the general reply at the bottom of the thread. We could use an icon near the post like redmine does, or a text link at the bottom of each post.

I can try and work a visualization of this.

Thanks, Michael. Just a note that, at the moment, there is no technical way to reply directly to a post in the middle of a thread; you can only respond to the whole thread. (See #28) So any "reply with quote" button will require a fair amount of jumping, possibly between pages (in order to get to the reply box at the end of the thread).

I think it's going to be pretty tough to do elegantly without working within a specific post. And as to #28, I agree that we should wait for the larger BP community to rework this. Are you able to track what features such as quoting are to be included?

And I'll post the wait and monitor suggestion on #28

This is a standard feature of discussion board platforms like PHPBb and SMF discussion boards. Examples abound, but here is one

I'm aware that quoting is a standard feature of forum platforms, but there are many different ways to implement it.

First of all, how do you choose what to quote? Do you highlight and use javascript to automatically beam to the box? Highlight manually and click quote? Click quote and copy the entire message you are quoting?

Second, what do you do with it in the Reply box? Do you use some form of forum markup like [quote]? Or real HTML like < blockquote >? Or do you use some fancy formatting with graphical inline indentation/background colors?

Third, what do you do with the quoted text after the reply is submitted? Indent? In quotation marks? Different color background? Do you have links back to the original quote (if so, that affects the use of things like [quote])?

Moreover, some of the more complex methods of quoting are going to degrade less gracefully in the absence of javascript, or in less-than-modern browsers.

In short, there should be some discussion about what such a system would look like ideally, at which point we can have a discussion about what is realistic and prudent from a development point of view.

Hmm, I used the user-switching plugin to login as you to see if I could duplicate the two things you mentioned, but couldn't.

Tested on Chrome 59 and Firefox 53.

Can you see if clearing your browser cache helps?

In the case of the scroll-to, https://github.com/cuny-academic-commons/cac/blob/1.11.x/wp-content/plugins/bbp-quote/bbp-quote.php#L113 is looking for this.hash. But (a) `this` is the <a> element, not its href, and (b) the format of the URL is commons.gc.cuny.edu/?p=12345, which doesn't have a hash.

For the 'Quote' part, https://github.com/cuny-academic-commons/cac/blob/1.11.x/wp-content/plugins/bbp-quote/bbp-quote.php#L137 $has_admin_links looks like this for me:

string 'Edit | Move | Split | Trash | Spam | Reply' (length=42)

Not sure what's happening here. If it's not obvious to you, I'll try to take some time to futz with it in the next day or two.

Ahh gotcha about the hash!

You were clicking on the Author wrote: part of the quote. I didn't account for those using the BP Forum Settings plugin, which uses a distinct permalink for the forum reply instead of the bbPress default that uses a hash.

Looking into it.

I'll see what I can do about the Quote link in the forum post bar.

Scroll-to should be fixed in https://github.com/cuny-academic-commons/cac/commit/3346e3f5261e098c0a110022592ce40037327335.

I've also updated the way the Quote link is added by using some newer bbPress filters in https://github.com/cuny-academic-commons/cac/commit/e15b10e355ce9356ea7d4d42d71b9f6751ad92b6.

Let me know if this fixes the problem for you.

Nice! Fixed on both counts.

I think this feature looks good.