CUNY Academic Commons

Here's the relevant data from the activity table:

id: 467129
date_recorded: 2017-08-15 17:56:57
type: new_groupblog_post

Sequentially, the id 467129 means that the activity item was created just this afternoon (at the date_recorded timestamp). It was not a modification of an existing activity item.

Ray, do you have a hypothesis about what might be happening here? Is it possible that the activity item corresponding to the original blog post was deleted, so that when the edit took place, bp-groupblog created a new activity item? If this is true, then why does the `action` read "...edited the blog post..." instead of "...wrote a new blog post..."?

I think that the following line might not be necessary anymore in bp-groupblog:
add_action( 'bp_activity_before_save', 'bp_groupblog_set_group_to_post_activity');

See:
https://github.com/boonebgorges/bp-groupblog/blob/1.8.x/bp-groupblog.php#L1211

This is because we are already hooking into the 'transition_post_status' hook to handle edits:
https://github.com/boonebgorges/bp-groupblog/blob/1.8.x/bp-groupblog.php#L1093

So what is happening at the moment is our edit activity catcher is running twice. Removing one of them should fix the issue. Does that sound about right, Boone?

And yes, I do believe the original activity item was somehow deleted.

Excellent - thanks, Ray. Perhaps it's linked to https://buddypress.trac.wordpress.org/ticket/6834?

If so, then making the same change to the mainline bp-groupblog plugin will effectively bump the minimum requirement to BP 2.5. Does that sound correct to you?

Boone, it looks like you're correct about BP ticket 6834.

This will indeed bump the requirement for bp-groupblog to BP v2.5 unless we check if the current version of BuddyPress is 2.5.

We could do the following inside bp_groupblog_catch_transition_post_type_status():

// If BP 2.5, bail.
if ( function_exists( 'bp_register_post_types' ) ) {
    return;
}

That way we keep compatibility with older versions.

Good call, Ray! I'll implement that.