CUNY Academic Commons

Related #2754 #10580 #19624

Sara, are you going to be building this as a Figma document for the dev team?

This is looking so great! Can we have the hover states bold like you have it but not make the size of the box it's in expand? hovering moves the vertical lines a bit and it feels better when they stay still. Attaching screen recording that shows the slight movement when the text bolds on hover. All in all though I'm super excited about this change and improvement!!! great work here

I've added to the figma file a slightly refreshed login dropdown

From the team meeting on Friday, we talked a tiny bit about adding back a CUNY Academic Commons icon to the admin bar when you are on a sub-site and logged out.

I've mocked up something with the smaller CAC logo with a little hover popup explaining that the current sub-site is part of the CUNY Academic Commons network. The "Learn more about us" button in the GIF links to the main Commons About page. Let me know what you think.

I played around with different options, and I like the first one personally. I would love to hear the group's thoughts

Updates on two fronts here, logo choice and testing feedback.

For the logo, we agreed to go with Option 1 from Sara's choices on desktop and to explore Options 6 and 7 on mobile (slight preference for 6 because of the full written Commons wording, but not sure if the text will be too small to read).

Regarding testing, Scott and I have done a pass through and have a few pieces of feedback below. Sara, have you taken a look yet?

- When you add a logo to a site or group, the logo image seems to appear twice in the corresponding admin bar drop-down item.

- Maybe this is a dev site thing, but there are broken images for the group logos in the drop-down, rather than the placeholder image. And on Firefox, the broken image message obscures the menu text. See screenshots for Firefox and Chrome.

- Maybe it's just us, but the way that the arrows flip up/down when you mouse over the drop-downs is a little laggy and distracting. Could that be improved? Or could it just be a static down-pointing arrow whether the menu is hovered/active or not?

For the logo, we agreed to go with Option 1 from Sara's choices on desktop and to explore Options 6 and 7 on mobile

I've added a first pass of Option 1 in https://github.com/cuny-academic-commons/cac/commit/ca63c61bdaa24b8dda324b81262c1c0df6f510ad. This is available for testing on cdev. I'll work on the mobile versions in later updates.

To confirm, we only wanted to add this logo item for logged-out users, correct?

- When you add a logo to a site or group, the logo image seems to appear twice in the corresponding admin bar drop-down item.

Confirmed, at least on the "My Sites" menu. I've added some code to remove the duplicate logo in the "My Sites" menu in https://github.com/cuny-academic-commons/cac/commit/adb2c52eb08482307fb3de0645f0f6a3124906d8. This is available for testing on cdev.

- Maybe this is a dev site thing, but there are broken images for the group logos in the drop-down

I was able to replicate some of the broken images for private site icons due to private site icons needing to be signed by S3 (also see #22966). I've added some code to address this in https://github.com/cuny-academic-commons/cac/compare/9a6bc07...33eb541. Boone, in https://github.com/cuny-academic-commons/cac/commit/6da28a3c81b80b0324e8a6f27f45910a1b109648, I'm mirroring the blog_public option to BP user blog meta so we can call it efficiently when in a bp_has_blogs() loop and have altered the cac_s3_uploads_is_site_private() function to utilize this. On production, we'll need to sync the blog_public option to blog meta, I've written a script located at ~/wp-cli-scripts/blog_public-sync.php that will need to run before deploying 2.7.0.

For the other broken images, it is likely a S3 / dev site thing. If you see broken images, try re-adding an image for the group or site in question to see if the image shows up again.

Maybe it's just us, but the way that the arrows flip up/down when you mouse over the drop-downs is a little laggy and distracting

I'm utilizing WordPress's built-in 'hover' CSS class here for the arrow flip, which only adds the CSS class when the menu is certain to open up in a mouseover state. This causes the inherent lagginess you are experiencing. (The WP admin bar uses the hoverIntent JS library for this.) If the arrow flip is distracting, I'll remove it and make it static like before.

I am good with a static arrow.

FYI In testing on cdev, the link is blue when I went to a site and the mobile view is a bit wonky (see screenshots)

Not sure if this is related the blue link Sara mentions in her last comment above, but Scott is also seeing some weird link color behavior when clicking on a My Sites dropdown item and looking at the toolbar in the WP dashboard of that site. See video attached. In his report to me, he says:

"It seems only to occur in the dashboard mode. In Firefox, for some reason (in incognito) , when I click one of my sites, the url changes to the home URL in the dashboard – maybe something with the test system is causing these weirdnesses."